-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change default path to show swagger #5640
Conversation
Locally the unit test I created works, but not sure if, due to connecting to localhost in the CI environment it can work. Any ideas on how to properly do it? Or if it is worth it? Thanks!! |
AWESOME!! already getting into it. |
also a bit odd why the proto ci is failing.. |
Yeah I saw that, can be like a random failure that happens sometimes in CI? That can be solved with a re-execution? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome -- great to see the contribution @jgimeno. Left some feedback on the test 👍
Also, we'll need a changelog entry under the Client Breaking Changes
section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 🌮
Closes: #5607
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)