Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Param Querying to x/auth #5702

Merged
merged 6 commits into from
Feb 26, 2020
Merged

Add Param Querying to x/auth #5702

merged 6 commits into from
Feb 26, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 26, 2020

  • Add parameter querying support to x/auth

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

x/evidence/types/msgs_test.go Outdated Show resolved Hide resolved
x/evidence/handler_test.go Outdated Show resolved Hide resolved
x/evidence/types/msgs_test.go Outdated Show resolved Hide resolved
x/evidence/handler_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #5702 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5702      +/-   ##
==========================================
- Coverage   35.47%   35.46%   -0.01%     
==========================================
  Files         331      331              
  Lines       32604    32612       +8     
==========================================
  Hits        11567    11567              
- Misses      19811    19819       +8     
  Partials     1226     1226              

@alexanderbez alexanderbez merged commit 8cab43c into master Feb 26, 2020
@alexanderbez alexanderbez deleted the bez/client-updates branch February 26, 2020 15:33
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants