Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standarize the representation of Governance param changes on cli requests. #5790

Merged

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Mar 11, 2020

Closes: #5783

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jgimeno jgimeno changed the title Standarize the representation of Gavernance param changes on cli requests. Standarize the representation of Governance param changes on cli requests. Mar 11, 2020
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #5790 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5790      +/-   ##
==========================================
- Coverage   36.07%   36.03%   -0.04%     
==========================================
  Files         341      342       +1     
  Lines       34735    34782      +47     
==========================================
+ Hits        12530    12534       +4     
- Misses      20957    20998      +41     
- Partials     1248     1250       +2
Impacted Files Coverage Δ
x/params/client/utils/utils.go 52.94% <ø> (ø) ⬆️
x/distribution/client/cli/utils.go 50% <ø> (+50%) ⬆️
x/distribution/client/cli/tx.go 4.7% <0%> (ø) ⬆️
x/params/client/cli/tx.go 0% <0%> (ø)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jgimeno -- just a few nitpicks.

x/gov/client/cli/parse.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
jgimeno and others added 3 commits March 12, 2020 14:17
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

@alexanderbez alexanderbez merged commit 241894a into master Mar 12, 2020
@alexanderbez alexanderbez deleted the jonathan/5783-standarize-representation-governance branch March 12, 2020 15:15
@alessio alessio mentioned this pull request Mar 17, 2020
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standarize deposit representation in governance proposal files
2 participants