Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes for keybase encoding. #5814

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Mar 17, 2020

Revert some changes done here:

#5799

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, can you confirm @alessio?

@alexanderbez alexanderbez added C:Encoding C:Keys Keybase, KMS and HSMs R4R labels Mar 17, 2020
@jgimeno
Copy link
Contributor Author

jgimeno commented Mar 17, 2020

@alexanderbez I added a comment for the breaking client on the changelog.

@jgimeno jgimeno mentioned this pull request Mar 17, 2020
11 tasks
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a request for an additional test case. Looks good otherwise

crypto/keys/keybase_base.go Show resolved Hide resolved
@alessio alessio merged commit 1c7da83 into master Mar 17, 2020
@alessio alessio deleted the jonathan/fix-keybase-back-serialization branch March 17, 2020 00:36
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #5814 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5814   +/-   ##
=======================================
  Coverage   36.03%   36.03%           
=======================================
  Files         342      342           
  Lines       34782    34782           
=======================================
  Hits        12534    12534           
  Misses      20998    20998           
  Partials     1250     1250
Impacted Files Coverage Δ
crypto/keys/keybase_base.go 72.51% <0%> (ø) ⬆️
crypto/keys/types.go 80.72% <100%> (ø) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Encoding C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants