Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: crypto/keys: detach DecodeSignature from baseKeybase struct #5838

Closed
wants to merge 2 commits into from

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 19, 2020

It makes more sense for DecodeSignature() to be a standalone function.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #5838 into master will increase coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5838      +/-   ##
==========================================
+ Coverage   32.33%   32.33%   +<.01%     
==========================================
  Files         353      353              
  Lines       39475    39477       +2     
==========================================
+ Hits        12763    12765       +2     
  Misses      25439    25439              
  Partials     1273     1273
Impacted Files Coverage Δ
crypto/keys/keyring.go 52.08% <100%> (+0.16%) ⬆️
crypto/keys/keybase.go 66.31% <100%> (+0.35%) ⬆️
crypto/keys/keybase_base.go 72.51% <50%> (ø) ⬆️
crypto/keys/lazy_keybase.go 56.89% <88.88%> (-0.37%) ⬇️

@alessio alessio added WIP and removed R4R labels Mar 20, 2020
@alessio alessio changed the title crypto/keys: detach DecodeSignature from baseKeybase struct WIP: crypto/keys: detach DecodeSignature from baseKeybase struct Mar 20, 2020
signing feature is unavailable for offline and multisign keys - they lack a private key
@alessio
Copy link
Contributor Author

alessio commented Mar 20, 2020

Superseded, see #5844

@alessio alessio closed this Mar 20, 2020
@alessio alessio deleted the alessio/factor-out-decode-signature branch March 20, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant