Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: show defaults when config help screen is displayed #5896

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 30, 2020

Closes: #5895
Thanks: @njmurarka for pointing this out.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #5896 into master will increase coverage by 0.04%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master    #5896      +/-   ##
==========================================
+ Coverage   56.80%   56.84%   +0.04%     
==========================================
  Files         342      342              
  Lines       20046    20060      +14     
==========================================
+ Hits        11388    11404      +16     
+ Misses       7808     7806       -2     
  Partials      850      850              

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alessio alessio merged commit b239cc8 into master Mar 31, 2020
@alessio alessio deleted the alessio/5895-config-show-defaults branch March 31, 2020 14:05
@ethanfrey ethanfrey mentioned this pull request Jun 30, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli config -- does not show available key options
2 participants