allow multiple transactions from the same account on the same block #5905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptophonic
requested review from
alessio,
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5905 +/- ##
=======================================
Coverage 57.06% 57.06%
=======================================
Files 342 342
Lines 20056 20056
=======================================
Hits 11444 11444
Misses 7767 7767
Partials 845 845
|
alexanderbez
reviewed
Apr 1, 2020
| @@ -219,10 +219,7 @@ func (svd SigVerificationDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simul | |||
| // IncrementSequenceDecorator handles incrementing sequences of all signers. | |||
| // Use the IncrementSequenceDecorator decorator to prevent replay attacks. Note, | |||
| // there is no need to execute IncrementSequenceDecorator on CheckTx or RecheckTX | |||
| // since it is merely updating the nonce. As a result, this has the side effect | |||
There was a problem hiding this comment.
I would undo this comment removal. The idea is still the same. BaseApp maintains two different states -- check and deliver state. Sending sequential txs for the same block can still be unreliable.
alexanderbez
reviewed
Apr 1, 2020
fedekunze
reviewed
Apr 1, 2020
alexanderbez
approved these changes
Apr 1, 2020
alexanderbez
suggested changes
Apr 1, 2020
| @@ -96,6 +96,7 @@ to now accept a `codec.JSONMarshaler` for modular serialization of genesis state | |||
| when method receivers are offline/multisig keys. | |||
| * (x/auth) [\#5892](https://github.com/cosmos/cosmos-sdk/pull/5892) Add `RegisterKeyTypeCodec` to register new | |||
| types (eg. keys) to the `auth` module internal amino codec. | |||
| * (x/auth) Allow more than one Tx per account per block | |||
There was a problem hiding this comment.
Suggested change
| * (x/auth) Allow more than one Tx per account per block | |
| * (x/auth) [\#5905](https://github.com/cosmos/cosmos-sdk/pull/5905) Fix `IncrementSequenceDecorator` to use is `IsReCheckTx` instead of `IsCheckTx` to allow account sequence incrementing. |
| @@ -219,10 +219,7 @@ func (svd SigVerificationDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simul | |||
| // IncrementSequenceDecorator handles incrementing sequences of all signers. | |||
| // Use the IncrementSequenceDecorator decorator to prevent replay attacks. Note, | |||
| // there is no need to execute IncrementSequenceDecorator on CheckTx or RecheckTX | |||
| // since it is merely updating the nonce. As a result, this has the side effect | |||
11 tasks
|
replaced by #5950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
Removes code that was preventing multiple transactions from being submitted from the same account in a single block, even if the transactions had correctly incremented sequence numbers and were submitted in the proper order.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)