Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST calls panic on some method call #5906

Merged
merged 5 commits into from
Apr 2, 2020

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Apr 1, 2020

Closes: #5869

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #5906 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5906   +/-   ##
=======================================
  Coverage   57.06%   57.06%           
=======================================
  Files         342      342           
  Lines       20056    20056           
=======================================
  Hits        11444    11444           
  Misses       7767     7767           
  Partials      845      845           

@jgimeno jgimeno marked this pull request as ready for review April 2, 2020 13:02
@jgimeno jgimeno changed the title REST fails on some methods REST calls panic on some method call Apr 2, 2020
@jgimeno jgimeno requested a review from okwme April 2, 2020 13:04
@alessio alessio added the R4R label Apr 2, 2020
@alessio alessio merged commit cc2a79c into master Apr 2, 2020
@alessio alessio deleted the jonathan/5869-rest-generate-only branch April 2, 2020 13:23
@alexanderbez
Copy link
Contributor

Thanks @jgimeno, great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests to REST client for simulate and generate_only
3 participants