Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ibc-alpha sims #5909

Merged
merged 3 commits into from
Apr 2, 2020
Merged

fix ibc-alpha sims #5909

merged 3 commits into from
Apr 2, 2020

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Apr 1, 2020

Description

Fixes build and sims


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze changed the title rename OpenTry -> TryOpen fix ibc-alpha sims Apr 1, 2020
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #5909 into ibc-alpha will increase coverage by 2.24%.
The diff coverage is 74.86%.

@@              Coverage Diff              @@
##           ibc-alpha    #5909      +/-   ##
=============================================
+ Coverage      57.06%   59.30%   +2.24%     
=============================================
  Files            342      397      +55     
  Lines          20056    22988    +2932     
=============================================
+ Hits           11444    13634    +2190     
- Misses          7767     8434     +667     
- Partials         845      920      +75     

@fedekunze fedekunze merged commit 8d26b7f into ibc-alpha Apr 2, 2020
@fedekunze fedekunze deleted the fedekunze/ibc-rename branch April 2, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants