-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/gov: Proto Tx CLI command #5942
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5942 +/- ##
=======================================
Coverage 58.23% 58.23%
=======================================
Files 396 396
Lines 23621 23621
=======================================
Hits 13756 13756
Misses 8905 8905
Partials 960 960 |
e29cb9c
to
23b7c90
Compare
This pull request introduces 3 alerts when merging a4dab80 into 8eb4808 - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging 9437697 into d10de8a - view on LGTM.com new alerts:
|
@alexanderbez I ran into some cyclic import issues here trying to import Going forward, I have the thought that |
Yeah I agree they should not need to import simulation if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @aaronc. Just a few minor nitpicks on variables.
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 🎉
Okay, all that stuff should be resolved now @alexanderbez |
ref: #5864
This PR implements protobuf tx CLI and REST endpoints for the
x/gov
module and in addition provides an example case of how to setup these commands with an interface handled by aoneof
at the app codec level. ADR 021 was updated to reflect the approach demonstrated in this PR.For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)