Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/params: Raw Parameter Querying #6005

Merged
merged 5 commits into from
Apr 16, 2020
Merged

x/params: Raw Parameter Querying #6005

merged 5 commits into from
Apr 16, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 16, 2020

Allow raw parameter querying by subspace. This is primarily motivated by the fact that we need to be able to query for non-module parameters (e.g. consensus parameters).

Note, this is not hooked up to the module manager, because it's Proto-ready.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez marked this pull request as ready for review April 16, 2020 15:40
@alexanderbez alexanderbez added R4R and removed WIP labels Apr 16, 2020
@alexanderbez alexanderbez self-assigned this Apr 16, 2020
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #6005 into master will decrease coverage by 0.15%.
The diff coverage is 2.63%.

@@            Coverage Diff             @@
##           master    #6005      +/-   ##
==========================================
- Coverage   55.54%   55.38%   -0.16%     
==========================================
  Files         420      423       +3     
  Lines       25293    25366      +73     
==========================================
+ Hits        14049    14050       +1     
- Misses      10275    10347      +72     
  Partials      969      969              

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alexanderbez alexanderbez merged commit 4da4bb6 into master Apr 16, 2020
@alexanderbez alexanderbez deleted the bez/params-querying branch April 16, 2020 16:23
@clevinson clevinson added this to the v0.39 milestone May 5, 2020
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants