add randomized consensus params into simulation #6051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6051 +/- ##
=======================================
Coverage 54.64% 54.64%
=======================================
Files 425 425
Lines 25815 25815
=======================================
Hits 14106 14106
Misses 10735 10735
Partials 974 974 |
…mos/cosmos-sdk into jonathan/5988-sim-params-consensus-2
jgimeno
requested review from
alessio,
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
fedekunze
approved these changes
Apr 22, 2020
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
| @@ -139,6 +139,7 @@ func TestAppImportExport(t *testing.T) { | |||
| ctxA := app.NewContext(true, abci.Header{Height: app.LastBlockHeight()}) | |||
| ctxB := newApp.NewContext(true, abci.Header{Height: app.LastBlockHeight()}) | |||
| newApp.mm.InitGenesis(ctxB, app.Codec(), genesisState) | |||
| newApp.StoreConsensusParams(ctxB, consensusParams) | |||
There was a problem hiding this comment.
Instead of having to make this method public (maybe it doesn't matter), perhaps instead we call newApp.InitChain() with the consensus params?
There was a problem hiding this comment.
I tried that on the beginning, but found several issues that was making the boilerplate too bid with the InitChainer. I can follow that but was too much iin my opinion.
I tried other ways too, using options, etc, but this was the less painful.
alexanderbez
added
the
A:automerge
alessio
changed the title
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* temporal commit * add random consensus params * make format * make random pass * remove comment * revert change * update ub key types * extract Evidence params from state * extract the random parameters from state * clean the code * update imports! * mispelled back * mispelled back * add misspelled command * update changelog * remove useless linter to avoid misspell * remove function * use tendermint constants * update import test * remove debug comment * Update baseapp/baseapp.go Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues: #6002
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)