Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: remove deprecated UpgradeOldPrivValFile #6079

Merged
merged 4 commits into from
Apr 27, 2020

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Apr 27, 2020

Description

OldFilePV was deprecated in Tendermint Core v0.28 and will be removed in
upcoming v0.34.5 release.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

OldFilePV was deprecated in Tendermint Core v0.28 and will be removed in
upcoming v0.34.5 release.
@melekes melekes reopened this Apr 27, 2020
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #6079 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6079   +/-   ##
=======================================
  Coverage   54.43%   54.43%           
=======================================
  Files         431      431           
  Lines       26157    26156    -1     
=======================================
  Hits        14239    14239           
+ Misses      10931    10930    -1     
  Partials      987      987           

@tac0turtle tac0turtle added A:automerge Automatically merge PR once all prerequisites pass. R4R labels Apr 27, 2020
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is worth the addition of a changelog item. Looks good otherwise 👍

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

@tac0turtle tac0turtle removed the A:automerge Automatically merge PR once all prerequisites pass. label Apr 27, 2020
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 27, 2020
@mergify mergify bot merged commit f0b72b9 into master Apr 27, 2020
@mergify mergify bot deleted the anton/remove-old-filepv branch April 27, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants