-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: remove deprecated UpgradeOldPrivValFile #6079
Conversation
OldFilePV was deprecated in Tendermint Core v0.28 and will be removed in upcoming v0.34.5 release.
Codecov Report
@@ Coverage Diff @@
## master #6079 +/- ##
=======================================
Coverage 54.43% 54.43%
=======================================
Files 431 431
Lines 26157 26156 -1
=======================================
Hits 14239 14239
+ Misses 10931 10930 -1
Partials 987 987 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is worth the addition of a changelog item. Looks good otherwise 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 🎉
Description
OldFilePV was deprecated in Tendermint Core v0.28 and will be removed in
upcoming v0.34.5 release.
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)