Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different db support #6219

Merged
merged 2 commits into from
May 14, 2020
Merged

Different db support #6219

merged 2 commits into from
May 14, 2020

Conversation

RiccardoM
Copy link
Contributor

Description

Adds the ability to use any of the database backend engines supported by Tendermint while creating new Cosmos databases.

closes: #6218

@auto-comment
Copy link

auto-comment bot commented May 14, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #6219 into master will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master    #6219   +/-   ##
=======================================
  Coverage   54.83%   54.84%           
=======================================
  Files         444      444           
  Lines       26771    26771           
=======================================
+ Hits        14681    14682    +1     
+ Misses      11048    11046    -2     
- Partials     1042     1043    +1     

@tac0turtle
Copy link
Member

did you start this branch off a release? I would recommend going off of master

@RiccardoM
Copy link
Contributor Author

did you start this branch off a release? I would recommend going off of master

Yeah I've started this off of v0.38.3 to make sure it was compatible with 0.38 as well as I think this might be useful to be also in v0.38.4

@RiccardoM
Copy link
Contributor Author

@marbar3778 Should be cleaner now as I've branched out of master and force pushed

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion. Looks good otherwise. Good call

types/utils.go Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Have you tried different backends @RiccardoM ?

@RiccardoM
Copy link
Contributor Author

utACK. Have you tried different backends @RiccardoM ?

I've tried using rocksdb as a backend and and it worked without any problem

@RiccardoM
Copy link
Contributor Author

Probably this can also be added to 0.38.4 as well

@alexanderbez alexanderbez merged commit bd90d6b into cosmos:master May 14, 2020
@alexanderbez alexanderbez mentioned this pull request May 14, 2020
6 tasks
alexanderbez pushed a commit that referenced this pull request May 19, 2020
@RiccardoM RiccardoM deleted the different-db-support branch May 27, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to use any Tendermint DB backend
4 participants