-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different db support #6219
Different db support #6219
Conversation
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been For contributor use:
For admin use:
Thank you for your contribution to the Cosmos-SDK! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #6219 +/- ##
=======================================
Coverage 54.83% 54.84%
=======================================
Files 444 444
Lines 26771 26771
=======================================
+ Hits 14681 14682 +1
+ Misses 11048 11046 -2
- Partials 1042 1043 +1 |
did you start this branch off a release? I would recommend going off of master |
Yeah I've started this off of |
@marbar3778 Should be cleaner now as I've branched out of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion. Looks good otherwise. Good call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. Have you tried different backends @RiccardoM ?
I've tried using |
Probably this can also be added to |
Description
Adds the ability to use any of the database backend engines supported by Tendermint while creating new Cosmos databases.
closes: #6218