x/ibc-transfer: move ICS20 out from x/ibc

[fedekunze]

Description

closes: #6092

[auto-comment]

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

[codecov]

Codecov Report

Merging #6222 into master will decrease coverage by 0.07%.
The diff coverage is 94.59%.

@@            Coverage Diff             @@
##           master    #6222      +/-   ##
==========================================
- Coverage   54.83%   54.75%   -0.08%     
==========================================
  Files         444      447       +3     
  Lines       26797    26894      +97     
==========================================
+ Hits        14693    14726      +33     
- Misses      11061    11124      +63     
- Partials     1043     1044       +1     

[tac0turtle]

should this be a submodule of bank? As a user at first glance it is hard to kow what the difference between bank and transfer is. will comment in the issue as well

[alexanderbez]

I don't think a sub-module of x/bank is the best idea, but I do agree x/transfer is generic and would cause a great deal of confusion with the already existing x/bank. I'd recommend something like x/ibc-transfer.

[fedekunze]

renamed to ibc-transfer

[alexanderbez]

LGTM

[alexanderbez]

There is a bit of commented-out code in this test file. I'd recommend removing it if it's not intended to be re-enabled.

[fedekunze]

yeah, there are a few places with that code commented. We can do that cleanup in #5558

[tac0turtle]

LGTM, thanks for changing to ibc-transfer