add github actions #6252
Merged
add github actions #6252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the ci won't run here because no go files were touched |
tac0turtle
requested review from
alessio,
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## rc0/v0.38.4 #6252 +/- ##
===============================================
- Coverage 54.36% 51.39% -2.97%
===============================================
Files 313 336 +23
Lines 19035 20551 +1516
===============================================
+ Hits 10348 10563 +215
- Misses 7890 9185 +1295
- Partials 797 803 +6 |
x/upgrade/alias.go
Outdated
| @@ -32,7 +32,7 @@ var ( | |||
| ) | |||
|
|
|||
| type ( | |||
| UpgradeHandler = types.UpgradeHandler | |||
| Handler = types.UpgradeHandler | |||
There was a problem hiding this comment.
golint throws linter error when how you call a pkg is also the first part of a func (upgrade.UpgradeHandler)
There was a problem hiding this comment.
Add a lint ignore. We shouldn't be renaming variables/types on aliasing. We need to address this in a follow-up on master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr adds github actions to the 0.38 series
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer