-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PublicKeyCodec #6372
Add PublicKeyCodec #6372
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6372 +/- ##
==========================================
- Coverage 55.61% 51.46% -4.15%
==========================================
Files 454 297 -157
Lines 27360 17022 -10338
==========================================
- Hits 15215 8761 -6454
+ Misses 11050 7673 -3377
+ Partials 1095 588 -507 |
…aronc/6213-pubkey-codec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, I will add to the tendermint tracking issue that the key types have been migrated to []byte
. Do you still need to register the old keys in a amino codec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Yes, for now we are providing amino backwards compatibility. |
you will then have to provide a cryptoamino codec similar to the one called from Tendermint. We are removing amino entirely. |
We've already added one ;) |
This is one of several bite-size PR's that are being pulled out of #6216 to implement #6213.
This adds:
crypto/types.PublicKeyCodec
interface for marshalingcrypto.PubKey
s to and from the protobufPublicKey
representationstd.DefaultPublicKeyCodec
which supports the standard public key types supported by the SDKBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer