Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Tx Message Data #6384

Merged
merged 5 commits into from
Jun 10, 2020
Merged

Enhance Tx Message Data #6384

merged 5 commits into from
Jun 10, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jun 10, 2020

Description

Introduce MsgData and TxData, when the Data returned after tx execution, contains a proto-encoded TxData, that contains a MsgData for each message in the tx. The MsgData includes the already proto-encoded data blob in addition to the message type for further context.

closes: #6375


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@alexanderbez alexanderbez marked this pull request as ready for review June 10, 2020 00:44
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #6384 into master will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #6384      +/-   ##
==========================================
- Coverage   55.60%   55.60%   -0.01%     
==========================================
  Files         457      457              
  Lines       27440    27444       +4     
==========================================
+ Hits        15257    15259       +2     
- Misses      11083    11084       +1     
- Partials     1100     1101       +1     

@fedekunze fedekunze merged commit c0aff2e into master Jun 10, 2020
@fedekunze fedekunze deleted the bez/enhance-tx-data-type branch June 10, 2020 08:02
@ethanfrey
Copy link
Contributor

Nice one @alexanderbez
Thank you!

@assafmo
Copy link
Contributor

assafmo commented Aug 5, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combining data fields with multiple messages is unusable
4 participants