Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TimeIotaMs to export GenesisFile #6510

Merged
merged 7 commits into from
Jun 26, 2020
Merged

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Jun 25, 2020

Description

Before we did not include the field time_iota_ms into the genesis file while exporting, now we do.

closes: ##6446


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@alexanderbez alexanderbez added A:automerge Automatically merge PR once all prerequisites pass. R4R labels Jun 25, 2020
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK -- thanks @jgimeno :D

@jgimeno
Copy link
Contributor Author

jgimeno commented Jun 25, 2020

@alexanderbez is it worth to have a test for this?

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #6510 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6510   +/-   ##
=======================================
  Coverage   56.36%   56.36%           
=======================================
  Files         470      470           
  Lines       28234    28234           
=======================================
  Hits        15913    15913           
  Misses      11195    11195           
  Partials     1126     1126           

@alexanderbez
Copy link
Contributor

@jgimeno yes, good idea. I would extract out the logic that updates the doc and just verify the consensus params 👍

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

return nil
},
}

cmd.Flags().Int64(flagHeight, -1, "Export state from a particular height (-1 means latest height)")
cmd.Flags().Bool(flagForZeroHeight, false, "Export state to start at height zero (perform preproccessing)")
cmd.Flags().StringSlice(flagJailWhitelist, []string{}, "List of validators to not jail state export")
cmd.SetOut(cmd.OutOrStdout())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try find a way to automatically call Set{Err,Out} for all commands at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants