store/types: Fix pruning opts validation #6511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
aaronc,
alessio,
clevinson,
fedekunze and
jgimeno
as code owners
alexanderbez
added
A:automerge
8 tasks
Codecov Report
@@ Coverage Diff @@
## master #6511 +/- ##
==========================================
+ Coverage 56.34% 56.36% +0.01%
==========================================
Files 470 470
Lines 28232 28234 +2
==========================================
+ Hits 15907 15913 +6
+ Misses 11200 11195 -5
- Partials 1125 1126 +1 |
fedekunze
approved these changes
Jun 25, 2020
| for _, tc := range testCases { | ||
| po := NewPruningOptions(tc.keepRecent, tc.keepEvery, tc.interval) | ||
| err := po.Validate() | ||
| require.Equal(t, tc.expectErr, err != nil, "options: %v, err: %s", po, err) |
There was a problem hiding this comment.
Suggested change
| require.Equal(t, tc.expectErr, err != nil, "options: %v, err: %s", po, err) | |
| if tc.expectErr { | |
| require.Error(t, err, po) | |
| } else { | |
| require.NoError(t, err, po) | |
| } |
jgimeno
approved these changes
Jun 25, 2020
alexanderbez
added a commit
that referenced
this pull request
Jun 25, 2020
* store/types: Fix pruning opts validation * store/types: Add case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer