Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick #5839 to Launchpad #6523

Closed
wants to merge 1 commit into from

Conversation

fedekunze
Copy link
Collaborator

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@fedekunze fedekunze marked this pull request as draft June 26, 2020 17:23
@fedekunze fedekunze changed the base branch from master to backport/release/v0.38.x June 26, 2020 17:27
@fedekunze fedekunze marked this pull request as ready for review June 26, 2020 17:28
@fedekunze fedekunze requested review from alexanderbez, alessio, aaronc, anilcse and clevinson and removed request for rigelrozanski June 26, 2020 17:29
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just cut the RC-1 release. Is this breaking change something we absolutely need?

@fedekunze
Copy link
Collaborator Author

Pasting my comment from Discord:

it's an API breaking change as well, but it'd be extremely beneficial for Aragon Chain and Ethermint bc we've been working from unstable commits since last year

Is this breaking change something we absolutely need?

It reverts the change from 0.38 that removed the sdk.Result from the simulation responses, so that we have the same behaviour as the 0.37.x series.

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. If you need to test this, you'll have to cut another RC and update the release entry.

@alexanderbez alexanderbez added this to the 0.39.0 [launchpad] milestone Jul 6, 2020
@alexanderbez alexanderbez changed the title cherry pick #5839 to 0.38.5 cherry pick #5839 to Launchpad Jul 6, 2020
@alexanderbez alexanderbez removed this from the 0.39.0 [launchpad] milestone Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants