Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates to #6713 #6777

Merged
merged 3 commits into from
Jul 18, 2020
Merged

Small updates to #6713 #6777

merged 3 commits into from
Jul 18, 2020

Conversation

clevinson
Copy link
Contributor

@clevinson clevinson commented Jul 18, 2020

Description

Few minor updates to address comments from @alexanderbez that came in after merge.

Ref: #6713


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #6777 into master will decrease coverage by 2.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6777      +/-   ##
==========================================
- Coverage   59.68%   57.09%   -2.59%     
==========================================
  Files         389      346      -43     
  Lines       25257    20179    -5078     
==========================================
- Hits        15075    11522    -3553     
+ Misses       9060     7803    -1257     
+ Partials     1122      854     -268     

@alexanderbez alexanderbez merged commit 8dcae70 into master Jul 18, 2020
@alexanderbez alexanderbez deleted the clevinson/updates-to-6713 branch July 18, 2020 17:56
chengwenxi pushed a commit to irisnet/cosmos-sdk that referenced this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants