Rename proto Req/Res to Pagination #6796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
amaury1093
added
the
T: Proto Breaking
Codecov Report
@@ Coverage Diff @@
## master #6796 +/- ##
=========================================
Coverage ? 50.46%
=========================================
Files ? 125
Lines ? 7573
Branches ? 0
=========================================
Hits ? 3822
Misses ? 3410
Partials ? 341 |
amaury1093
changed the title
alexanderbez
approved these changes
Jul 20, 2020
sahith-narahari
approved these changes
Jul 20, 2020
sahith-narahari
added
the
A:automerge
chengwenxi
pushed a commit
to irisnet/cosmos-sdk
that referenced
this pull request
Jul 22, 2020
* Rename proto Req to Pagination * Change Res to Pagination Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #6664 (comment)
Remove
Req/Res, usePagination(same field name for PageRequest & PageResponse).We use
paginationalready in some comments, tests, and imo it's a clearer name than other candidates (paging, page_info, page_request, page_response)Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes