Fix for 6786 removeZeroCoins mutates original slice #6811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iramiller
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6811 +/- ##
==========================================
- Coverage 61.29% 61.29% -0.01%
==========================================
Files 510 510
Lines 31640 31634 -6
==========================================
- Hits 19395 19391 -4
+ Misses 10729 10727 -2
Partials 1516 1516 |
iramiller
requested review from
aaronc,
alessio,
clevinson,
fedekunze and
jgimeno
as code owners
fedekunze
approved these changes
Jul 22, 2020
amaury1093
approved these changes
Jul 28, 2020
amaury1093
added
the
A:automerge
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two new unit test cases, one for Coin and one for DecCoin that fail on the existing code base in order to demonstrate the manipulation of the source array as described. The modifications to the Coin and DecCoin 'remove zero balance coin' functions address these issues and make the two added tests pass successfully.
closes: #6786
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes