Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/{distribution, staking, bank, mint, crisis} genesis protobuf migration #6835

Merged
merged 23 commits into from
Jul 28, 2020
Merged

x/{distribution, staking, bank, mint, crisis} genesis protobuf migration #6835

merged 23 commits into from
Jul 28, 2020

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jul 24, 2020 •
edited by sahith-narahari
Loading

Description

ref: #5917

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aaronc aaronc mentioned this pull request Jul 24, 2020
Closed
16 tasks
@codecov
Copy link

codecov bot commented Jul 24, 2020 •
edited
Loading

Codecov Report

Merging #6835 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6835   +/-   ##
=======================================
  Coverage   61.29%   61.29%           
=======================================
  Files         510      510           
  Lines       31640    31640           
=======================================
  Hits        19395    19395           
  Misses      10729    10729           
  Partials     1516     1516

@aaronc aaronc changed the title x/distribution genesis protobuf migration x/{distribution,staking} genesis protobuf migration Jul 24, 2020
@atheeshp atheeshp changed the title x/{distribution,staking} genesis protobuf migration x/{distribution, staking, bank, mint} genesis protobuf migration Jul 24, 2020
@atheeshp atheeshp changed the title x/{distribution, staking, bank, mint} genesis protobuf migration x/{distribution, staking, bank, mint, crisis} genesis protobuf migration Jul 24, 2020
amaury1093
amaury1093 reviewed Jul 27, 2020
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick scan, lgtm for now

proto/cosmos/crisis/crisis.proto Outdated Show resolved Hide resolved
@sahith-narahari sahith-narahari marked this pull request as ready for review July 27, 2020 17:30
aaronc
aaronc approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 🎉

@aaronc aaronc added A:automerge Automatically merge PR once all prerequisites pass. C:Encoding C:x/bank C:x/crisis C:x/distribution distribution module related C:x/mint C:x/staking labels Jul 27, 2020
blushi
blushi reviewed Jul 28, 2020
View reviewed changes
Copy link
Contributor

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me too, though conflicts still need to get fixed.

amaury1093
amaury1093 approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@mergify mergify bot merged commit b33b1e9 into master Jul 28, 2020
@mergify mergify bot deleted the atheesh/5917-proto-migration branch July 28, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blushi blushi blushi left review comments

@amaury1093 amaury1093 amaury1093 approved these changes

@aaronc aaronc aaronc approved these changes

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@clevinson clevinson Awaiting requested review from clevinson

@fedekunze fedekunze Awaiting requested review from fedekunze

@jgimeno jgimeno Awaiting requested review from jgimeno

@anilcse anilcse Awaiting requested review from anilcse

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Encoding C:x/bank C:x/crisis C:x/distribution distribution module related C:x/mint C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atheeshp @aaronc @amaury1093 @blushi @sahith-narahari