Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Makefile for build on windows #703

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Fixing Makefile for build on windows #703

merged 1 commit into from
Mar 27, 2018

Conversation

faboweb
Copy link
Contributor

@faboweb faboweb commented Mar 26, 2018

Closes #536

@faboweb faboweb requested a review from ebuchman as a code owner March 26, 2018 09:41
@codecov
Copy link

codecov bot commented Mar 26, 2018 •
edited
Loading

Codecov Report

Merging #703 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #703   +/-   ##
========================================
  Coverage    65.75%   65.75%           
========================================
  Files           41       41           
  Lines         1977     1977           
========================================
  Hits          1300     1300           
  Misses         566      566           
  Partials       111      111

@faboweb faboweb changed the base branch from master to develop March 26, 2018 09:45
@rigelrozanski rigelrozanski merged commit 24a01c7 into develop Mar 27, 2018
@rigelrozanski rigelrozanski deleted the fabo/536-fixed-build-windows branch March 27, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faboweb @rigelrozanski