Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show_node_id command (closes #704) #705

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Mar 26, 2018

Ref #704 (just show_node_id, not the rest of the command set yet)

@cwgoes cwgoes requested a review from ebuchman as a code owner March 26, 2018 18:20
@cwgoes cwgoes requested a review from rigelrozanski March 26, 2018 18:20
@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #705 into develop will decrease coverage by 0.49%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop     #705     +/-   ##
==========================================
- Coverage    65.75%   65.26%   -0.5%     
==========================================
  Files           41       42      +1     
  Lines         1977     1992     +15     
==========================================
  Hits          1300     1300             
- Misses         566      581     +15     
  Partials       111      111

Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to refactor all these commands to have the funcs defined in the cobra.Command - when the func is so small it's confusing to have to have an extra type to relay the information. - but will refactor all together

@rigelrozanski rigelrozanski merged commit fb1a949 into develop Mar 26, 2018
@rigelrozanski rigelrozanski deleted the cwgoes/show_node_id branch March 26, 2018 18:31
@martindale
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants