Add show_validator command from tendermint to basecoind #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #710 +/- ##
===========================================
+ Coverage 64.04% 64.74% +0.69%
===========================================
Files 43 43
Lines 2022 2008 -14
===========================================
+ Hits 1295 1300 +5
+ Misses 615 597 -18
+ Partials 112 111 -1 |
server/show_validator.go
Outdated
| return err | ||
| } | ||
| privValidator := types.LoadOrGenPrivValidatorFS(cfg.PrivValidatorFile()) | ||
| pubKeyJSONBytes, _ := data.ToJSON(privValidator.PubKey) |
There was a problem hiding this comment.
we should handle this error instead of just _ing it?
There was a problem hiding this comment.
I just copied this from Tendermint (which doesn't handle the error). Presumably the encoding will never fail?
Probably worth fixing anyways though.
|
@rigelrozanski OK? |
cwgoes
force-pushed
the
cwgoes/show_validator
branch
from
f35653a to
fef3e15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #704