-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Vesting Account Message #7209
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7209 +/- ##
==========================================
- Coverage 55.16% 55.14% -0.02%
==========================================
Files 580 584 +4
Lines 40359 40512 +153
==========================================
+ Hits 22263 22341 +78
- Misses 16233 16301 +68
- Partials 1863 1870 +7 |
…osmos-sdk into bez/4287-create-vesting-acc-msg
@cwgoes I need to undo commit d34ef20 that contains your recommendation, because we call Either we
Thoughts? |
Ah, I see. Is the issue with the Duplicating the |
x/bank/handler.go
Outdated
@@ -30,14 +30,6 @@ func NewHandler(k keeper.Keeper) sdk.Handler { | |||
|
|||
// Handle MsgSend. | |||
func handleMsgSend(ctx sdk.Context, k keeper.Keeper, msg *types.MsgSend) (*sdk.Result, error) { | |||
if err := k.SendEnabledCoins(ctx, msg.Amount...); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume these had to do with vesting accounts? Is this logic moved elsewhere now or is it irrelevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing to do with vesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was moved to x/bank SendCoins
to keep code DRY
…osmos-sdk into bez/4287-create-vesting-acc-msg
Updated @cwgoes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 🎉
Who else should review this, maybe @AdityaSripal @alessio? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'll give this another day or so before I merge. Note, @cwgoes I had to revert the DRY changes you've suggested. It was causing issues with InitGenesis because we end up having transfers disabled for some seeds which causes x/staking InitGenesis to fail. We should eventually refactor the way we send coins to make it more flexible (e.g. add a parameter to |
Description
x/auth/vesting
into a proper sub-module (implementsAppModuleBasic
andAppModule
)MsgCreateVestingAccount
message and corresponding handlerx/auth/vesting
to create aMsgCreateVestingAccount
tx (only delayed and continuous accounts can be made)Note, we're still not allowing a custom
start_time
.closes: #4287
/cc @zmanian @cwgoes
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes