rename RegisterCodec to RegisterLegacyAminoCodec #7243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7243 +/- ##
==========================================
- Coverage 54.92% 54.22% -0.70%
==========================================
Files 575 425 -150
Lines 39544 30565 -8979
==========================================
- Hits 21718 16574 -5144
+ Misses 16032 12661 -3371
+ Partials 1794 1330 -464 |
anilcse
requested review from
aaronc,
alessio and
alexanderbez
as code owners
anilcse
requested review from
amaury1093,
atheeshp,
blushi,
clevinson and
fedekunze
fedekunze
approved these changes
Sep 5, 2020
blushi
approved these changes
Sep 7, 2020
amaury1093
approved these changes
Sep 7, 2020
There was a problem hiding this comment.
Thanks @anilcse, good idea!
There's also the New() function in /codec/amino.go, I think it would be good to replace codec.New() by codec.NewLegacyAmino(), wdyt? In this PR or a later one.
Updated |
amaury1093
approved these changes
Sep 7, 2020
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
fedekunze
added
the
A:automerge
…e_register_codec # Conflicts: # x/distribution/client/cli/tx_test.go
…-sdk into anil/rename_register_codec
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* rename RegisterCodec to RegisterLegacyAminoCodec * Add changelog * gofmt * rename codec.New() to codec.NewLegacyAmino() * Add change log * Update CHANGELOG.md Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> * Fix Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Module's
RegisterCodecis bit ambiguous, it states that it registers any given codec but registers onlyLegacyAminocodec.RegisterLegacyAminoCodecis self explanatoryRegisterCodectoRegisterLegacyAminoCodeccodec.New()tocodec.NewLegacyAmino()Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes