Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 'cool' and 'sketchy' modules from basecoin to democoin #748

Merged
merged 3 commits into from
Mar 30, 2018
Merged

Move 'cool' and 'sketchy' modules from basecoin to democoin #748

merged 3 commits into from
Mar 30, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Mar 30, 2018

Remove demonstration modules from basecoind (soon-to-be gaiad?) and associated testcases

@cwgoes cwgoes requested a review from ebuchman as a code owner March 30, 2018 14:32
@codecov
Copy link

codecov bot commented Mar 30, 2018 •
edited
Loading

Codecov Report

Merging #748 into develop will not change coverage.
The diff coverage is 87.5%.

@@           Coverage Diff            @@
##           develop     #748   +/-   ##
========================================
  Coverage    59.41%   59.41%           
========================================
  Files           62       62           
  Lines         3262     3262           
========================================
  Hits          1938     1938           
  Misses        1183     1183           
  Partials       141      141

rigelrozanski
rigelrozanski suggested changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good - we should not just straight up delete - Please move to a new example named democoin or maybe something of the likes that keeps this code here as reference

@cwgoes cwgoes changed the title Remove 'cool' and 'sketchy' modules from basecoin Move 'cool' and 'sketchy' modules from basecoin to democoin Mar 30, 2018
@rigelrozanski rigelrozanski merged commit 15e3d47 into develop Mar 30, 2018
@rigelrozanski rigelrozanski deleted the cwgoes/clean-up-basecoin branch March 30, 2018 20:32
@cwgoes cwgoes mentioned this pull request Mar 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwgoes @rigelrozanski