Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog and version #763

Merged
merged 1 commit into from
Apr 1, 2018
Merged

changelog and version #763

merged 1 commit into from
Apr 1, 2018

Conversation

ebuchman
Copy link
Member

We should be making this kind of version bump immediately after release

@codecov
Copy link

codecov bot commented Mar 31, 2018

Codecov Report

Merging #763 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #763   +/-   ##
========================================
  Coverage    59.25%   59.25%           
========================================
  Files           62       62           
  Lines         3286     3286           
========================================
  Hits          1947     1947           
  Misses        1194     1194           
  Partials       145      145

@cwgoes
Copy link
Contributor

cwgoes commented Apr 1, 2018

And future PRs to develop should include changelog entries for the pending changelog?

@ebuchman
Copy link
Member Author

ebuchman commented Apr 1, 2018

I think we should be including the changelog in the PR opening comment rather than in the PR itself else we'll have conflicts all over the place if theres lots of open PRs

@ebuchman ebuchman merged commit e509590 into develop Apr 1, 2018
@ebuchman ebuchman deleted the bucky/changelog branch April 1, 2018 18:47
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants