fix inconsistent flag names in upgrade proposal command #7697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
aaronc,
alessio and
alexanderbez
as code owners
anilcse
approved these changes
Oct 28, 2020
amaury1093
reviewed
Oct 28, 2020
yihuang
force-pushed
the
upgrade-flags
branch
from
9550107
to
f8ff0d9
Compare
Codecov Report
@@ Coverage Diff @@
## master #7697 +/- ##
=======================================
Coverage 54.11% 54.11%
=======================================
Files 611 611
Lines 38571 38571
=======================================
Hits 20871 20871
Misses 15573 15573
Partials 2127 2127 |
amaury1093
approved these changes
Oct 28, 2020
amaury1093
added
the
A:automerge
alessio
reviewed
Oct 28, 2020
| @@ -19,8 +19,8 @@ const ( | |||
| TimeFormat = "2006-01-02T15:04:05Z" | |||
|
|
|||
| FlagUpgradeHeight = "upgrade-height" | |||
| FlagUpgradeTime = "time" | |||
| FlagUpgradeInfo = "info" | |||
| FlagUpgradeTime = "upgrade-time" | |||
There was a problem hiding this comment.
This is good, yet why not just changing update-height to height? Considering that the command itself is named software-upgrade, flags upgrade- prefix has always sounded a bit of an unnecessary repetition IMHO
There was a problem hiding this comment.
--height might be confusing with other usage? when query stuff, there's usually a block height parameter.
There was a problem hiding this comment.
--height is a flag for query commands only. It should be safe to reuse it here - please check it out in client/flags 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the flag names in command "tx gov submit-proposal software-upgrade" is not consistent with the name suggest in help messages.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes