-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ibc: tendermint misbehaviour should use block hash for equality check #7928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
(just to confirm: we don't check this anywhere else?) |
Codecov Report
@@ Coverage Diff @@
## master #7928 +/- ##
==========================================
- Coverage 54.18% 54.17% -0.01%
==========================================
Files 612 612
Lines 39000 39000
==========================================
- Hits 21131 21129 -2
- Misses 15697 15698 +1
- Partials 2172 2173 +1 |
…cosmos-sdk into colin/7911-block-hash-inequality
good call, I updated |
Description
closes: #7911
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes