Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc: tendermint misbehaviour should use block hash for equality check #7928

Merged
merged 8 commits into from
Nov 13, 2020

Conversation

colin-axner
Copy link
Contributor

Description

closes: #7911


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@colin-axner colin-axner added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 13, 2020
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes
Copy link
Contributor

cwgoes commented Nov 13, 2020

(just to confirm: we don't check this anywhere else?)

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #7928 (39562d5) into master (a8ef4a3) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #7928      +/-   ##
==========================================
- Coverage   54.18%   54.17%   -0.01%     
==========================================
  Files         612      612              
  Lines       39000    39000              
==========================================
- Hits        21131    21129       -2     
- Misses      15697    15698       +1     
- Partials     2172     2173       +1     

@colin-axner colin-axner removed the A:automerge Automatically merge PR once all prerequisites pass. label Nov 13, 2020
@colin-axner
Copy link
Contributor Author

(just to confirm: we don't check this anywhere else?)

good call, I updated ValidCommit to use the block ID hash as well

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 13, 2020
@mergify mergify bot merged commit 7e6978a into master Nov 13, 2020
@mergify mergify bot deleted the colin/7911-block-hash-inequality branch November 13, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

07-tendermint: check hash inequality instead of block ID inequality
4 participants