Add fee grant module #8061

atheeshp · 2020-12-02T09:10:08Z

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

…ee-delegation-new

x/feegrant/types/basic_fee.go

proto/cosmos/feegrant/v1beta1/feegrant.proto

…fee-grant

atheeshp · 2021-01-28T09:49:34Z

@amaurymartiny can you have a look again. Thanks!

docs/core/proto-docs.md

amaury1093

lgtm, thanks @atheeshp !

Still not sure about having 2 antehandlers in the SDK (one normal, one normal+feegrant), but I don't want to block this PR on that.

x/feegrant/types/key.go

x/feegrant/ante/fee_test.go

atheeshp · 2021-01-28T15:10:02Z

@anilcse , @blushi , @robert-zaremba can you guys have a look again

blushi

lgtm but it'd be good to add some more docs in proto definitions.

proto/cosmos/feegrant/v1beta1/feegrant.proto

blushi

LGTM

aaronc · 2021-01-29T17:24:00Z

@anilcse @robert-zaremba can you please re-review soon as your reviews are currently blocking this, or let us know you'd like your change request dismissed. Thanks 🙏

anilcse

lgtm

anilcse · 2021-01-29T18:34:52Z

client/context.go

@@ -166,6 +167,13 @@ func (ctx Context) WithFromAddress(addr sdk.AccAddress) Context {
 	return ctx
 }

+// WithFeeGranterAddress returns a copy of the context with an updated fee granter account
+// address.
+func (ctx Context) WithFeeGranterAddress(addr sdk.AccAddress) Context {


Suggested change

func (ctx Context) WithFeeGranterAddress(addr sdk.AccAddress) Context {

func (ctx Context) WithFeeGranter(addr sdk.AccAddress) Context {

robert-zaremba

Approving - left one suggestion re HasDefinedTime

robert-zaremba · 2021-01-29T19:53:43Z

x/feegrant/types/expiration.go

+}
+
+// HasDefinedTime returns true if `ExpiresAt` has valid time
+func (e ExpiresAt) HasDefinedTime() bool {


We have Undefined method, so for symmetry , how about calling this method IsDefined?

* Add docs * Add BasicFeeAllowance implementation * Add expiration structs and complete basic fee * Add delegation messages, add validation logic * Add keeper and helper structs * Add alias and handler to top level * Add delegation module * Add basic querier * Add types tests * Add types tests * More internal test coverage * Solid internal test coverage * Expose Querier to top level module * Add FeeAccount to auth/types, like StdTx, SignDoc * Fix all tests in x/auth * All tests pass * Appease the Golang Linter * Add fee-account command line flag * Start on DelegatedDeductFeeDecorator * Cleanup the Decorator * Wire up delegation module in simapp * add basic test for decorator (no delegation) * Table tests for deduct fees * Table tests over all conditions of delegated fee decorator * Build full ante handler stack and test it * Start genesis * Implement Genesis * Rename package delegation to subkeys * Clarify antes test cases, handle empty account w/o fees * Allow paying delegated fees with no account * Pull mempool into delegated ante, for control on StdFee * Use custom DelegatedTx, DelegatedFee for subkeys * Revert all changes to x/auth.StdTx * Appease scopelint * Register DelegatedTx with codec * Address PR comments * Remove unnecessary DelegatedMempoolFeeDecorator * Cleaned up errors in querier * Clean up message sign bytes * Minor PR comments * Replace GetAllFees... with Iterator variants * PrepareForExport adjusts grant expiration height * Panic on de/serialization error in keeper * Move custom ante handler chain to tests, update docs * More cleanup * More doc cleanup * Renamed subkeys module to fee_grant * Rename subkeys/delegation to fee grant in all strings * Modify Msg and Keeper methods to use Grant not Delegate * Add PeriodicFeeAllowance * Update aliases * Cover all accept cases for PeriodicFeeAllowance * Et tu scopelint? * Update docs as requested * Remove error return from GetFeeGrant * Code cleanup as requested by PR * Updated all errors to use new sdk/errors package * Use test suite for keeper tests * Clean up alias.go file * Define expected interfaces in exported, rather than importing from account * Remove dependency on auth/ante * Improve godoc, Logger * Cleaned up ExpiresAt * Improve error reporting with UseGrantedFee * Enforce period limit subset of basic limit * Add events * Rename fee_grant to feegrant * Ensure KeeperTestSuite actually runs * Move types/tx to types * Update alias file, include ante * I do need nolint in alias.go * Properly emit events in the handler. Use cosmos-sdk in amino types * Update godoc * Linting... * Update errors * Update pkg doc and fix ante-handler order * Merge PR cosmos#5782: Migrate x/feegrant to proto * fix errors * proto changes * proto changes * fix errors * fix errors * genesis state changed to proto * fix keeper tests * fix test * fixed tests * fix tests * updated expected keepers * updated ante tests * lint * deleted alias.go * tx updated to proto tx * remove explicit signmode * tests * Added `cli/query.go` * Added tx.go in cli * updated `module.go` * resolve errors in tx.go * Add fee payer gentx func * updated tx * fixed error * WIP: cli tests * fix query error * fix tests * Unused types and funcs * fix tests * rename helper func to create tx * remove unused * update tx cfg * fix cli tests * added simulations * Add `decoder.go` * fix build fail * added init genesis code * update tx.go * fixed LGTM alert * modified cli * remove gogoproto extensions * change acc address type to string * lint * fix simulations * Add gen simulations * remove legacy querier * remove legacy code * add grpc queries tests * fix simulations * update module.go * lint * register feegrant NewSimulationManager * fix sims * fix sims * add genesis test * add periodic grant * updated cmd * changed times * updated flags * removed days as period clock * added condition for period and exp * add periodic fee cli tests * udpated tests * fix lint * fix tests * fix sims * renaming to `fee_grant` * review changes * fix test * add condition for duplicate grants * fix tests * add `genTxWithFeeGranter` in tests * fix simulation * one of changes & test fixes * fix test * fix lint * changed package name `feegrant` to `fee_grant` * review comments * review changes * review change * review changes * added fee-account in flags * address review changes * read fee granter from cli * updated create account with mnemonic * Address review comments * move `simapp/ante` file to `feegrant/ante` * update keeper logic to create account * update docs * fix tests * update `serviceMsgClientConn` from `msgservice` * review changes * add test case for using more fees than allowed * eliminate panic checks from keeper * fix lint * change store keys string to bytes * fix tests * review changes * review changes * udpate docs * make spend limit optional * fix tests * fix tests * review changes * add norace tag * proto-docs * add docs Co-authored-by: Ethan Frey <ethanfrey@users.noreply.github.com> Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com> Co-authored-by: SaReN <sahithnarahari@gmail.com> Co-authored-by: aleem1413 <aleem@vitwit.com> Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com> Co-authored-by: Anil Kumar Kammari <anil@vitwit.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

ethanfrey and others added 30 commits October 16, 2019 10:22

Add docs

abce938

Add BasicFeeAllowance implementation

ea6fe7d

Add expiration structs and complete basic fee

c46153c

Add delegation messages, add validation logic

42c17f5

Add keeper and helper structs

0c137cb

Add alias and handler to top level

67cb830

Add delegation module

f6ba9bc

Add basic querier

a002366

Add types tests

15c6361

Add types tests

410d1f1

More internal test coverage

f65db09

Solid internal test coverage

e0f6327

Expose Querier to top level module

93c9b7e

Add FeeAccount to auth/types, like StdTx, SignDoc

7968441

Fix all tests in x/auth

7e82fb8

All tests pass

64d5159

Appease the Golang Linter

8b2b64b

Merge remote-tracking branch 'origin/master' into cg-key-management/f…

4e22edd

…ee-delegation-new

Add fee-account command line flag

be12b44

Start on DelegatedDeductFeeDecorator

c703e59

Cleanup the Decorator

907776f

Wire up delegation module in simapp

005afd9

add basic test for decorator (no delegation)

45c64d2

Table tests for deduct fees

87fd0ce

Table tests over all conditions of delegated fee decorator

d03c650

Build full ante handler stack and test it

e476c03

Start genesis

182eb34

Implement Genesis

071e111

Merge branch 'master' into cg-key-management/fee-delegation-new

0a362b8

Rename package delegation to subkeys

98b88a3

amaury1093 reviewed Jan 27, 2021

View reviewed changes

x/feegrant/types/basic_fee.go Outdated Show resolved Hide resolved

proto/cosmos/feegrant/v1beta1/feegrant.proto Show resolved Hide resolved

atheeshp added 3 commits January 28, 2021 15:04

make spend limit optional

f2b616f

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/x-…

d2cc66e

…fee-grant

fix tests

c172cca

anilcse reviewed Jan 28, 2021

View reviewed changes

docs/core/proto-docs.md Outdated Show resolved Hide resolved

fix tests

8d8f137

atheeshp requested review from amaury1093 and anilcse January 28, 2021 10:13

amaury1093 approved these changes Jan 28, 2021

View reviewed changes

x/feegrant/types/key.go Outdated Show resolved Hide resolved

x/feegrant/ante/fee_test.go Show resolved Hide resolved

atheeshp added 3 commits January 28, 2021 16:16

review changes

3dfb3ab

add norace tag

3398c46

proto-docs

a344c78

blushi reviewed Jan 28, 2021

View reviewed changes

proto/cosmos/feegrant/v1beta1/feegrant.proto Outdated Show resolved Hide resolved

proto/cosmos/feegrant/v1beta1/feegrant.proto Outdated Show resolved Hide resolved

add docs

6509b55

atheeshp requested a review from blushi January 28, 2021 16:01

Merge branch 'master' into atheesh/x-fee-grant

fc5b9e1

blushi approved these changes Jan 29, 2021

View reviewed changes

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 29, 2021

anilcse approved these changes Jan 29, 2021

View reviewed changes

Merge branch 'master' into atheesh/x-fee-grant

4987bd0

robert-zaremba approved these changes Jan 29, 2021

View reviewed changes

mergify bot merged commit d97e790 into master Jan 29, 2021

mergify bot deleted the atheesh/x-fee-grant branch January 29, 2021 19:54

atheeshp mentioned this pull request Feb 1, 2021

Enable Fee Delegation #5768

Closed

15 tasks

aaronc removed the in progress label Feb 2, 2021

egonspace mentioned this pull request Nov 15, 2021

feat: feegrant module Finschia/finschia-sdk#380

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fee grant module #8061

Add fee grant module #8061

atheeshp commented Dec 2, 2020

atheeshp commented Jan 28, 2021

amaury1093 left a comment

atheeshp commented Jan 28, 2021

blushi left a comment •

edited

Loading

blushi left a comment

aaronc commented Jan 29, 2021

anilcse left a comment

anilcse Jan 29, 2021

robert-zaremba left a comment

robert-zaremba Jan 29, 2021

	func (ctx Context) WithFeeGranterAddress(addr sdk.AccAddress) Context {
	func (ctx Context) WithFeeGranter(addr sdk.AccAddress) Context {

Add fee grant module #8061

Add fee grant module #8061

Conversation

atheeshp commented Dec 2, 2020

atheeshp commented Jan 28, 2021

amaury1093 left a comment

Choose a reason for hiding this comment

atheeshp commented Jan 28, 2021

blushi left a comment • edited Loading

Choose a reason for hiding this comment

blushi left a comment

Choose a reason for hiding this comment

aaronc commented Jan 29, 2021

anilcse left a comment

Choose a reason for hiding this comment

anilcse Jan 29, 2021

Choose a reason for hiding this comment

robert-zaremba left a comment

Choose a reason for hiding this comment

robert-zaremba Jan 29, 2021

Choose a reason for hiding this comment

blushi left a comment •

edited

Loading