Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Signature only flag bug on tx sign command 7632 #8106

Merged
merged 47 commits into from
Dec 14, 2020
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
351c28f
fix: Signature only flag bug on tx sign command 7632
robert-zaremba Dec 7, 2020
4308f1c
Update client/context.go
robert-zaremba Dec 8, 2020
942d954
Merge branch 'master' into robert/fix-cli-sign
robert-zaremba Dec 8, 2020
86e1ca7
Update client/context.go
robert-zaremba Dec 8, 2020
50568a4
Merge branch 'master' into robert/fix-cli-sign
sahith-narahari Dec 8, 2020
09984c6
use named return value and closure (#8111)
Dec 8, 2020
b97a939
set the right 'append' logic for signing transactions
robert-zaremba Dec 8, 2020
7d96902
cleanup
robert-zaremba Dec 8, 2020
a0d26fb
update tx.Sign interface by adding overwrite option
robert-zaremba Dec 8, 2020
ac324b3
Update Changelog
robert-zaremba Dec 8, 2020
1b16901
sign command cleanup
robert-zaremba Dec 8, 2020
9d5ce97
implementation and changelog update
robert-zaremba Dec 9, 2020
e774b31
fix SignTx and tx.Sign calls
robert-zaremba Dec 9, 2020
e731b5a
fix: sign didn't write to a file
robert-zaremba Dec 9, 2020
4784d93
update flags description
robert-zaremba Dec 9, 2020
2048a8a
Merge branch 'master' into robert/fix-cli-sign
robert-zaremba Dec 9, 2020
b1e3cbd
Add tx.Sign tests
robert-zaremba Dec 9, 2020
edc19dc
fix grpc/server_test.go
robert-zaremba Dec 9, 2020
8818f64
Update client/tx/tx.go
robert-zaremba Dec 9, 2020
7e39258
changelog update
robert-zaremba Dec 10, 2020
3ed4d36
Add test to verify matching signatures
robert-zaremba Dec 10, 2020
cd6b700
cli_test: add integration tests for sign CMD
robert-zaremba Dec 10, 2020
fe3acef
add output-file flag test
robert-zaremba Dec 10, 2020
c2c74c6
add flagAmino test
robert-zaremba Dec 10, 2020
82d28b8
Update x/auth/client/cli/tx_sign.go
robert-zaremba Dec 10, 2020
87d027a
Update x/auth/client/cli/tx_sign.go
Dec 10, 2020
b8256a8
update amino serialization test
robert-zaremba Dec 10, 2020
a00e8ec
TestSign: adding unit test for signing with different modes
robert-zaremba Dec 10, 2020
c0c1c48
Add test with Multi Signers into Robert's TxSign PR (#8142)
amaury1093 Dec 11, 2020
6405295
cleanups
robert-zaremba Dec 11, 2020
9b9b9dc
Merge branch 'master' into robert/fix-cli-sign
robert-zaremba Dec 11, 2020
d61f340
client.Sign: raise error when signing tx with multiple signers in Direct
robert-zaremba Dec 11, 2020
8cbcff1
add more tests
robert-zaremba Dec 11, 2020
25e4915
Update client/tx/tx_test.go
robert-zaremba Dec 12, 2020
17f210b
fix TestGetBroadcastCommand_WithoutOfflineFlag
robert-zaremba Dec 12, 2020
46b50b2
Any.UnsafeSetCachedValue
robert-zaremba Dec 14, 2020
8e55e13
fix note packed messages in tx builder
robert-zaremba Dec 14, 2020
a263570
reorder unit tests
robert-zaremba Dec 14, 2020
68d9b37
Changelog update
robert-zaremba Dec 14, 2020
febbca9
cleaning / linting
robert-zaremba Dec 14, 2020
ae2ce73
cli_tes: copy validator object instead of modifying it's shared codec
robert-zaremba Dec 14, 2020
1407caa
x/auth cli_test: remove custom codec creation in tests
robert-zaremba Dec 14, 2020
d71fe5a
Merge branch 'master' into robert/fix-cli-sign
mergify[bot] Dec 14, 2020
df7be40
Update CHANGELOG.md
clevinson Dec 14, 2020
94c42a0
updates to CHANGELOG.md
clevinson Dec 14, 2020
48659f8
remove unused method
robert-zaremba Dec 14, 2020
5547aaa
add new instance of transaction builder for TestSign
robert-zaremba Dec 14, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updates to CHANGELOG.md
clevinson authored Dec 14, 2020
commit 94c42a08d6c8f8b435e7d4bf8b216475e857dea9
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -53,11 +53,11 @@ Ref: https://keepachangelog.com/en/1.0.0/

### State Machine Breaking Changes

* (x/upgrade) [\#7632](https://github.com/cosmos/cosmos-sdk/issues/7632) keeper pubkey storage serialization migration from bech32 to protobuf.
* (x/upgrade) [\#7979](https://github.com/cosmos/cosmos-sdk/pull/7979) keeper pubkey storage serialization migration from bech32 to protobuf.


### Features
* (codec/types) []() Adding `NewAnyWithCustomTypeURL` to correctly marshal Messages in TxBuilder.
* (codec/types) [\#8106](https://github.com/cosmos/cosmos-sdk/pull/8106) Adding `NewAnyWithCustomTypeURL` to correctly marshal Messages in TxBuilder.

### Bug Fixes