-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api, config: modular server #8210
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8210 +/- ##
==========================================
- Coverage 61.91% 61.88% -0.03%
==========================================
Files 609 609
Lines 35101 35098 -3
==========================================
- Hits 21732 21721 -11
- Misses 11085 11096 +11
+ Partials 2284 2281 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's great you're getting a head start on these changes to test out ideas and theories. the proposal needs to be properly vetted and evaluated by team members via an ADR.
@alexanderbez yes I plan to do that before marking the PR ready for review. I'm figuring out the components and requirements now to write a complete ADR for it |
…8208-modular-server
…8208-modular-server
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@fedekunze, I'm going close this for now since the ADR was closed as well. The branch will live on. |
Description
closes: #8208
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes