Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api, config: modular server #8210

Closed
wants to merge 11 commits into from
Closed

Conversation

fedekunze
Copy link
Collaborator

Description

closes: #8208


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #8210 (4c90a06) into master (3257618) will decrease coverage by 0.02%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8210      +/-   ##
==========================================
- Coverage   61.91%   61.88%   -0.03%     
==========================================
  Files         609      609              
  Lines       35101    35098       -3     
==========================================
- Hits        21732    21721      -11     
- Misses      11085    11096      +11     
+ Partials     2284     2281       -3     
Impacted Files Coverage Δ
server/config/toml.go 18.18% <0.00%> (ø)
server/grpc/server.go 62.50% <ø> (ø)
simapp/app.go 82.88% <0.00%> (-1.91%) ⬇️
server/config/config.go 39.77% <33.33%> (+0.23%) ⬆️
testutil/network/network.go 90.54% <100.00%> (ø)
testutil/network/util.go 72.91% <100.00%> (ø)
client/rpc/block.go 0.00% <0.00%> (-10.00%) ⬇️
types/simulation/account.go 84.00% <0.00%> (-1.72%) ⬇️
simapp/simd/cmd/root.go 59.83% <0.00%> (-1.33%) ⬇️
... and 12 more

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's great you're getting a head start on these changes to test out ideas and theories. the proposal needs to be properly vetted and evaluated by team members via an ADR.

@fedekunze
Copy link
Collaborator Author

@alexanderbez yes I plan to do that before marking the PR ready for review. I'm figuring out the components and requirements now to write a complete ADR for it

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 2, 2021
@fedekunze fedekunze added pinned and removed stale labels Mar 2, 2021
@tac0turtle
Copy link
Member

@fedekunze, I'm going close this for now since the ADR was closed as well. The branch will live on.

@tac0turtle tac0turtle closed this Apr 16, 2021
@alexanderbez alexanderbez deleted the fedekunze/8208-modular-server branch April 22, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modular server
3 participants