[backport/v0.41.x] x/crisis - general audit and cleanup (#8269) #8303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update docs * review changes Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
aleem1314
requested review from
aaronc,
alessio and
alexanderbez
as code owners
amaury1093
approved these changes
Jan 12, 2021
amaury1093
added
A:automerge
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
anilcse
approved these changes
Jan 12, 2021
robert-zaremba
requested changes
Jan 14, 2021
…osmos-sdk into aleem/crisis-docs-audit
I can see only one event in the crisis module. |
aleem1314
changed the title
amaury1093
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
imo this is good to go, the events page seems correct. @robert-zaremba could you give a final review?
amaury1093
added
backports/0.41.x (Stargate)
and removed
backport/0.40.x (Stargate)
A:automerge
|
@aleem1314 could you rebase this PR to |
* update docs * review changes Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
…osmos-sdk into aleem/crisis-docs-audit
clevinson
changed the title
|
@alessio Do you have rights to merge this PR? |
alessio
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #8269
update docs
review changes
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes