Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[appd] fix: gRPC web address default flag value #8399

Merged
merged 4 commits into from
Jan 22, 2021

Conversation

fdymylja
Copy link
Contributor

Description

The grpc-web address flag was using the grpc address flag default value instead of its own, this was causing address binding conflicts.

This PR fixes this.

On a secondary note, it appears that disabling grpc-web via flags is ignored (or overridden).

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre approving. Don't forget about changelog update.

@robert-zaremba
Copy link
Collaborator

@alessio , @fdymylja - should we backport this to release/0.40.x as well? if yes then don't forget to add tag and create a new PR as this will be merged.

@fdymylja
Copy link
Contributor Author

@alessio , @fdymylja - should we backport this to release/0.40.x as well? if yes then don't forget to add tag and create a new PR as this will be merged.

I think we should. Also it appears that the grpc-web.enable flag is being ignored.

@sahith-narahari sahith-narahari mentioned this pull request Jan 21, 2021
9 tasks
@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 22, 2021
@mergify mergify bot merged commit 5ed1151 into master Jan 22, 2021
@mergify mergify bot deleted the fdymylja/fix-grpc-web-flag branch January 22, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants