Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query signing infos command #8427

Merged
merged 3 commits into from
Jan 26, 2021
Merged

Fix query signing infos command #8427

merged 3 commits into from
Jan 26, 2021

Conversation

chengwenxi
Copy link
Contributor

@chengwenxi chengwenxi commented Jan 25, 2021 •
edited
Loading

Description

No args for this command.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

amaury1093
amaury1093 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks

fedekunze
fedekunze approved these changes Jan 25, 2021
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack can you add a changelog entry?

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 26, 2021
@mergify mergify bot merged commit 50b4be9 into master Jan 26, 2021
@mergify mergify bot deleted the vincent/signing-infos branch January 26, 2021 09:32
@0Tech 0Tech mentioned this pull request Dec 20, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/slashing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chengwenxi @amaury1093 @fedekunze