-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport/v0.41.x]: fix: bind values from env variables to flags #8488
Conversation
/cc @amaurymartiny |
@troian ah yeah, no worries then, I'll do a sprint myself to create backport PRs for the ones before this one 👍. Putting this to draft for now. |
Is there a corresponding PR for this fix in master already? I'm struggling to find what this relates to. Ideally this should be merged into master and then backported to the |
86af8c1
to
40aab82
Compare
allows clients access values in env variables Signed-off-by: Artur Troian <troian.ap@gmail.com>
Codecov Report
@@ Coverage Diff @@
## release/v0.41.x #8488 +/- ##
===================================================
- Coverage 61.93% 61.92% -0.01%
===================================================
Files 611 611
Lines 35250 35241 -9
===================================================
- Hits 21831 21822 -9
Misses 11136 11136
Partials 2283 2283
|
Unfortunately I cannot seem to get a consistent test running, I've been running those in ubuntu docker (same as the one in the CI), but I keep getting different test fails. Unfortunately I cannot even debug it, apparently, as the target build system is linux and setting up a dockerized debugger is too complex with win-docker. |
Let me take a look |
allows clients access values in env variables
From: #8337