Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit header in MsgUpdateClient events #8624

Merged
merged 23 commits into from
Mar 3, 2021
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
47d6a77
emit header in update client msg
colin-axner Feb 18, 2021
600e954
update CHANGELOG
colin-axner Feb 18, 2021
3d824ff
update spec
colin-axner Feb 18, 2021
5c82a98
Merge branch 'master' into colin/8598-update-header-event
Feb 18, 2021
ccea83b
fix nil header bug
colin-axner Feb 18, 2021
8ce1f53
Merge branch 'colin/8598-update-header-event' of github.com:cosmos/co…
colin-axner Feb 18, 2021
1ea4081
use JSON encoding for emitting header
colin-axner Feb 19, 2021
401abdc
Update x/ibc/core/spec/06_events.md
fedekunze Feb 27, 2021
0052d40
use proto for encoding
colin-axner Mar 1, 2021
046ae44
add tests
colin-axner Mar 1, 2021
1462ce6
Merge branch 'colin/8598-update-header-event' of github.com:cosmos/co…
colin-axner Mar 1, 2021
a08b336
fix changelog merge conflict
colin-axner Mar 1, 2021
df9dbfa
merge master
colin-axner Mar 1, 2021
732431c
Merge branch 'master' into colin/8598-update-header-event
colin-axner Mar 1, 2021
3f4773e
encode to hex before emitting header in event
colin-axner Mar 2, 2021
9ffcbe9
Merge branch 'colin/8598-update-header-event' of github.com:cosmos/co…
colin-axner Mar 2, 2021
cb28f10
add comment addressing reasoning for hex encoding
colin-axner Mar 2, 2021
cde3dad
Merge branch 'master' into colin/8598-update-header-event
colin-axner Mar 2, 2021
d639449
Merge branch 'master' into colin/8598-update-header-event
colin-axner Mar 3, 2021
75ee333
Merge branch 'master' into colin/8598-update-header-event
colin-axner Mar 3, 2021
bcaab1a
Merge branch 'master' into colin/8598-update-header-event
colin-axner Mar 3, 2021
1165dad
Update CHANGELOG.md
colin-axner Mar 3, 2021
6cad885
Merge branch 'master' into colin/8598-update-header-event
colin-axner Mar 3, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Improvements

* (x/ibc)[\#8624](https://github.com/cosmos/cosmos-sdk/pull/8624) Emit full header in IBC UpdateClient message.
colin-axner marked this conversation as resolved.
Show resolved Hide resolved

### Bug Fixes

* (x/evidence) [#8461](https://github.com/cosmos/cosmos-sdk/pull/8461) Fix bech32 prefix in evidence validator address conversion
Expand Down
1 change: 1 addition & 0 deletions x/ibc/core/02-client/keeper/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ func (k Keeper) UpdateClient(ctx sdk.Context, clientID string, header exported.H
sdk.NewAttribute(types.AttributeKeyClientID, clientID),
sdk.NewAttribute(types.AttributeKeyClientType, clientState.ClientType()),
sdk.NewAttribute(types.AttributeKeyConsensusHeight, consensusHeight.String()),
sdk.NewAttribute(types.AttributeKeyHeader, header.String()),
),
)

Expand Down
1 change: 1 addition & 0 deletions x/ibc/core/02-client/types/events.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const (
AttributeKeySubjectClientID = "subject_client_id"
AttributeKeyClientType = "client_type"
AttributeKeyConsensusHeight = "consensus_height"
AttributeKeyHeader = "header"
)

// IBC client events vars
Expand Down
1 change: 1 addition & 0 deletions x/ibc/core/spec/06_events.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ callbacks to IBC applications.
| update_client | client_id | {clientId} |
| update_client | client_type | {clientType} |
| update_client | consensus_height | {consensusHeight} |
| update_cleint | header | {header} |
fedekunze marked this conversation as resolved.
Show resolved Hide resolved
| message | action | update_client |
| message | module | ibc_client |

Expand Down