-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate SetFullFundraiserPath in favor of SetPurpose and SetCoinType #8629
Deprecate SetFullFundraiserPath in favor of SetPurpose and SetCoinType #8629
Conversation
…ype and renamed GetFullFundraiserPath to GetFullBip44Path
Codecov Report
@@ Coverage Diff @@
## master #8629 +/- ##
=======================================
Coverage 61.47% 61.47%
=======================================
Files 659 659
Lines 37876 37881 +5
=======================================
+ Hits 23283 23287 +4
- Misses 12159 12160 +1
Partials 2434 2434
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Please add an API breaking change Changelog entry
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of removing SetFullFundraiserPath()
and GetFullFundraiserPath()
, I'd like to see both functions being marked as deprecated. We'll remove them in a future release. An example of a deprecation comment follows:
// ModTime returns the modification time in UTC using the legacy
// ModifiedDate and ModifiedTime fields.
//
// Deprecated: Use Modified instead.
func (h *FileHeader) ModTime() time.Time {
return msDosTimeToTime(h.ModifiedDate, h.ModifiedTime)
}
Done 👍 |
Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com>
…h' into remove-set-full-fundraiser-path
Description
This PR removes the
SetFullFundraiserPath
method in favor of distinctSetPurpose
andSetCoinType
methods. It also renames theGetFullFundraiserPath
method toGetFullBip44Path
.This is done in order to simplify the code that chains should write when using a custom coin type. Right now, they must call two distinct methods:
With this PR, it would be simplified to
This because the BIP-44 path is now generated considering the data put inside the
sdk.Config
object instead of taking the full path from outside.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes