Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jonathan/remove unused import pub #8704

Merged

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Feb 25, 2021

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jgimeno jgimeno changed the base branch from master to sahith/fix-key-multi February 25, 2021 18:01
crypto/keyring/keyring.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #8704 (d4c796d) into sahith/fix-key-multi (2539acd) will decrease coverage by 0.09%.
The diff coverage is 49.74%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           sahith/fix-key-multi    #8704      +/-   ##
========================================================
- Coverage                 61.46%   61.37%   -0.10%     
========================================================
  Files                       659      670      +11     
  Lines                     37932    38267     +335     
========================================================
+ Hits                      23316    23487     +171     
- Misses                    12172    12327     +155     
- Partials                   2444     2453       +9     
Impacted Files Coverage Δ
crypto/keyring/keyring.go 59.17% <0.00%> (-0.83%) ⬇️
types/module/module.go 82.71% <ø> (ø)
x/bank/legacy/v040/keys.go 0.00% <ø> (ø)
x/gov/legacy/v040/keys.go 0.00% <0.00%> (ø)
x/slashing/legacy/v040/keys.go 0.00% <0.00%> (ø)
x/staking/legacy/v040/keys.go 0.00% <0.00%> (ø)
client/keys/migrate.go 46.37% <42.85%> (+2.89%) ⬆️
x/bank/keeper/migrations.go 50.00% <50.00%> (+50.00%) ⬆️
x/distribution/keeper/migrations.go 50.00% <50.00%> (ø)
x/gov/keeper/migrations.go 50.00% <50.00%> (ø)
... and 31 more

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Copy link
Contributor

@sahith-narahari sahith-narahari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should I merge this @jgimeno

@sahith-narahari sahith-narahari marked this pull request as ready for review February 26, 2021 07:24
@sahith-narahari sahith-narahari merged commit eb03b8f into sahith/fix-key-multi Feb 26, 2021
@sahith-narahari sahith-narahari deleted the jonathan/remove-unused-import-pub branch February 26, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants