Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IBC from the SDK #8735

Merged
merged 12 commits into from
Mar 4, 2021
Merged

Remove IBC from the SDK #8735

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
baa4c66
remove IBC
colin-axner Feb 22, 2021
2daec73
remove ibc from simapp
colin-axner Feb 22, 2021
54d72bf
merge master
colin-axner Mar 1, 2021
e7691c4
update README's
colin-axner Mar 1, 2021
d08d452
update docs README
colin-axner Mar 1, 2021
62999f8
merge master
colin-axner Mar 1, 2021
37a13ce
remove auth test and run make proto-all
colin-axner Mar 1, 2021
05ce789
remove capability ibc test
colin-axner Mar 1, 2021
1be3e7f
fix docs README for ibc
colin-axner Mar 2, 2021
2b7f74a
merge master
colin-axner Mar 4, 2021
dda7b01
fix hardcoded test
colin-axner Mar 4, 2021
ab27bc3
Merge branch 'master' into colin/remove-ibc
colin-axner Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions x/capability/keeper/keeper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,16 +114,6 @@ func (suite *KeeperTestSuite) TestNewCapability() {
suite.Require().Nil(cap)
}

func (suite *KeeperTestSuite) TestOriginalCapabilityKeeper() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdityaSripal should I replace this test with something? If so, how?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh this is testing the original capability keeper in simapp since that was holding a capability for transfer. Now that simapp no longer does that, we don't need this test.

I would remove it.

got, ok := suite.app.ScopedIBCKeeper.GetCapability(suite.ctx, "invalid")
suite.Require().False(ok)
suite.Require().Nil(got)

port, ok := suite.app.ScopedIBCKeeper.GetCapability(suite.ctx, "ports/transfer")
suite.Require().True(ok)
suite.Require().NotNil(port)
}

func (suite *KeeperTestSuite) TestAuthenticateCapability() {
sk1 := suite.keeper.ScopeToModule(banktypes.ModuleName)
sk2 := suite.keeper.ScopeToModule(stakingtypes.ModuleName)
Expand Down