-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Gov Deposits Querier (Initial Deposit) #8813
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8813 +/- ##
==========================================
- Coverage 59.37% 59.30% -0.08%
==========================================
Files 563 563
Lines 31270 31306 +36
==========================================
- Hits 18566 18565 -1
- Misses 10546 10583 +37
Partials 2158 2158
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good and makes sense to me, thanks a lot!
@YunSuk-Yeo Could you add a E2E test? I think we could add a test in the CLI, in x/gov/client/cli/cli_test.go
.
} | ||
} | ||
|
||
return types.Deposit{}, fmt.Errorf("failed to find the initial deposit for proposalID %d", proposalID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you use sdkerrors.Wrapf here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @YunSuk-Yeo
@YunSuk-Yeo Any update on tests and fixing merge conflicts here? |
@YunSuk-Yeo any news? Or else someone on the SDK team could copy the PR and fix the conflicts? |
With no response, we are forking this branch and adding tests: #9288 |
Description
closes: #8758
Deposits querier must include initial deposit by querying submit proposal
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes