-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add reverse iteration to pagination #8875
Conversation
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=56800fd6c28244c5bf8a9e57208cff95 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=7b3e1557892303a33a2630372429c818609d0ee8 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=801632610464533d33d05ddb3e94358afb4187b3 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=a222c503e2df692183e648607ea2bba6c9c81015 |
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=2cd44cb80a074512baf9cd1d013885fe |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=dc409797a37f12511a52f583f3b21aded3673d03 |
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=df3b2ef3495a4bf08be3e5b2ee14739c |
…mos/cosmos-sdk into aleem/8754-reverse-iteration
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=14572d6dd841d752b5bcf5616f7b0a05a3ad1cf3 |
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=7f1013471c0349fc80343f14dfac59c0 |
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=1ee094aa005046efb0c282ad7744fdb9 |
Codecov Report
@@ Coverage Diff @@
## master #8875 +/- ##
==========================================
- Coverage 58.91% 58.88% -0.04%
==========================================
Files 574 571 -3
Lines 32122 32114 -8
==========================================
- Hits 18924 18909 -15
- Misses 10979 10983 +4
- Partials 2219 2222 +3
|
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=09e6d6f498c9e2b2e1fb46b2a045bc0b6c94ebd0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=e376cd2fe46fc6adf032bb18b027f8284dede60e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, can you add a changelog entry? 🙏
* WIP * add tests * add tests * fix lint * fix pagination * add proto message doc * fix filtered_pagination * fix test * cleanup * add reverse flag to pagination * changelog * Update client/flags/flags.go * Update CHANGELOG.md Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit a78f777)
Description
closes: #8754
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes