-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 0.43 CLI JSON migrate
command
#8880
Conversation
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=3705c0e0b7d54f9b805cfb526292b1e5 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=68a2a66137fe5277e2c446d033ad2e446f1016f4 |
Codecov Report
@@ Coverage Diff @@
## master #8880 +/- ##
==========================================
- Coverage 59.27% 59.25% -0.03%
==========================================
Files 571 572 +1
Lines 31827 31813 -14
==========================================
- Hits 18867 18850 -17
- Misses 10757 10761 +4
+ Partials 2203 2202 -1
|
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=8dd825b81e8977a756c651e390e55e0848c07c73 |
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=8e74cd1e82144091a9733749a42dfb9d |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=26263696dfdc8bbd6570860e8b3bd120d3f3cdff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. Left one question.
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=2e69bb2b1cab561deaf07f73472ff9e0a07898b5 |
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=d9a7604fefbd4750a753e8ff56909ef2 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=8d9b776c56cf2902cf44d9cedf416efb97c9d7e9 |
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=449186f4624d44778638f24109a87563 |
migrate
commandmigrate
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks go. ACK'd. I couldn't test it, @AmauryM did you or anyone test this manually?
I ran the following:
It doesn't test all migration paths (it only ran for a few blocks), more thorough testing is desirable, but requires a testnet probably. |
Description
closes: #8822
To Test:
simd export > test.json
simd migrate v0.43 test.json
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes