Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/distribution: fix module's parameters validation #8918

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 17, 2021

closes: #8914


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alessio alessio force-pushed the alessio/8914-update-params-validation branch from 9115634 to af872fe Compare March 17, 2021 19:40
@orijbot
Copy link

orijbot commented Mar 17, 2021

Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

x/distribution/types/params_internal_test.go Outdated Show resolved Hide resolved
x/distribution/types/params_test.go Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@alexanderbez alexanderbez added the C:x/distribution distribution module related label Mar 17, 2021
@orijbot
Copy link

orijbot commented Mar 17, 2021

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@orijbot
Copy link

orijbot commented Mar 17, 2021

@orijbot
Copy link

orijbot commented Mar 17, 2021

@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 17, 2021
@orijbot
Copy link

orijbot commented Mar 17, 2021

@alessio
Copy link
Contributor Author

alessio commented Mar 17, 2021

@zmanian @shahankhatch this looks state-breaking, i.e. parameters that were valid before will no longer be so once this patch is merged in. It must be said that even though this patch might potentially break applications state, any application that uses such invalid parameters would be anyway misusing the distribution module.

Here is the conundrum: should we backport it and include it in v0.42.2 or should we be gentle and mindful about those clients who misuse the Cosmos SDK?

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #8918 (b01cd9a) into master (0836361) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8918      +/-   ##
==========================================
+ Coverage   59.17%   59.24%   +0.06%     
==========================================
  Files         571      571              
  Lines       31807    31807              
==========================================
+ Hits        18822    18844      +22     
+ Misses      10782    10760      -22     
  Partials     2203     2203              
Impacted Files Coverage Δ
x/distribution/types/params.go 81.25% <100.00%> (+34.37%) ⬆️

@mergify mergify bot merged commit 1fddce7 into master Mar 17, 2021
@mergify mergify bot deleted the alessio/8914-update-params-validation branch March 17, 2021 20:06
@orijbot
Copy link

orijbot commented Mar 17, 2021

@orijbot
Copy link

orijbot commented Mar 17, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/distribution distribution module related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

community tax + base proposer reward + bonus proposer reward > 1 would break distribution module
5 participants