-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix genesis supply handling #8930
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8930 +/- ##
==========================================
+ Coverage 59.27% 59.33% +0.05%
==========================================
Files 571 572 +1
Lines 31827 31854 +27
==========================================
+ Hits 18867 18902 +35
+ Misses 10757 10744 -13
- Partials 2203 2208 +5
|
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=d135f086e14ae67269ba53b9d4c791c6794c5000 |
@aaronc I added a test to the supply calculation. afaict this PR is R4R, unless you had something else in mind? |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=0eb10f290584e7fd6c0352e5de6e3b5fade7d1f1 |
I think this should be backported right? It's not state breaking. It just would help new chains with their genesis. |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=4caa7e4bc1424c4a3b0644e173bed006bfac3e9f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Mergifyio backport release/v0.42.x |
* Fix genesis supply handling * Add test * Fix nit Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit e9e978d) # Conflicts: # x/bank/keeper/genesis.go # x/bank/types/genesis.go
Command
|
Description
closes: #8919
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes